CFMU 1.0 Released

07/21/2009 | CFMU | 21 Comments

I am happy to announce the release of my CFMU project as its finally hit version 1.0. I was able to fix a couple bugs so I figured no time like the present to get this out. I was able to fix one bug that was forwarded to me by a user. The user was having an issue with the max file size, basically it just was not working. The problem was with the flash vars being passed into the application. Its important to note that flash vars are case sensitive when your reading them in. If you have a second and you have not checked out the project yet, please do and let me know your thoughts.

This entry was posted on July 21, 2009 at 12:43 AM and has received 3703 views. Comments 21 | Print this entry.

TweetBacks

Comments (Comment Moderation is enabled. Your comment will not appear until approved.)

[Add Comment] [Subscribe to Comments]

#1 by Steve Withington on 7/21/09 - 11:52 PM

Dan,
Congrats on reaching v1.0! And thanks!
#2 by Ken Smith on 7/28/09 - 10:42 AM

Hey Dan, this is a nice project. We have been bangong our heads against the wall trying to figure out how to pass some variables that will be passed to the Uploader.cfc page. We have added attributes and flashvars on uploader.cfm, but they dont get trhough to the cfc. Is there an easy way to do this, or would we need to change the flex source? Sorry if this is covered elsewhere.

Thanks,
#3 by Dan Vega on 7/28/09 - 10:46 AM

Can you please give me an example of what you are trying to do? I just had someone go through a problem like this and before I blog about it I want to make sure it is the same.

Basically you can properties using the upload URL. uploader.cfc?method=upload&param1=1&param2=2
#4 by Ken Smith on 7/28/09 - 11:37 AM

Thanks for the quick response:

Hope my code doesn't get all munged...

We tried sending it in the url, like this:

   <cfmodule template="../cfmu/uploader.cfm"
       basePath="../cfmu/"
       id="filter-uploader"
       title="My Image Uploader"
       width="400"
       height="300"
       url="../demo/uploader.cfc?method=test&bucketName=thisshouldwork"
       dir="#expandPath('.')#\images\"
       filters="#filters#"
          />
Notice the "bucketName" param...

Then outputting it in the cflog like this:

   <cffunction name="upload" access="remote" output="true" returntype="string" >
      <cfargument name="bucketName" default="didntwork" required="false" />

      <cffile action="upload" filefield="Filedata" destination="#form.path#\#form.filename#" nameconflict="makeunique" />
      <cflog text="4: #bucketName#" />
      <cfreturn bucketName>
   </cffunction>

But it will not write the value we passed in.

I think it has to do with this code in uploader.cfm:

<param name="flashVars" value="url=#attributes.url#&title=#attributes.title#&dir=#attributes.dir#&progressBarLabel=#attributes.progressBarLabel#&filters=#filtersString#&confirmDeleteMSG=#attributes.confirmDeleteMSG#&onComplete=#attributes.onComplete#&maxFileSize=#attributes.maxFileSize#&maxFiles=#attributes.maxFiles#" />

Because the line would then read:

<param name="flashVars" value="url=../demo/uploader.cfc?method=test&bucketName=thisshouldwork&title=#attributes.title#...

See how the bucketName param is now being passed to flashvars instead of being included in the url param?

Thanks again for looking at this, I'm probably just doing something wrong...
#5 by Ken Smith on 7/28/09 - 11:47 AM

Never Mind, we got it. Instead of doing this: uploader.cfc?method=upload&param1=1&param2=2

You should do this: uploader.cfc?method=upload%26param1=1%26param2=2

And that fixes it.
#6 by Kurt Graber on 7/29/09 - 10:07 AM

Dan,
I am trying to use the onComplete functionality of CFMU to reload the page and display the uploaded images below the uploader. When I call the onComplete it seems like it's firing before the upload is complete.

Here is the cfmodule:
<cfmodule template="/upload/cfmu/uploader.cfm"
       basePath="/upload/cfmu/"
       id="filter-uploader"
       title="DocumentManager Document Uploader"
       width="400"
       height="300"
       url="/upload/uploadAndInsert.cfm?bucketName=#bucketName#%26formField=#formField#%26fileName=#fileName#%26fileAction=#fileAction#%26folderName=#folderName#%26title=#title#%26description=#description#%26recipientID=#recipientID#%26loggedInUserID=#loggedInUserID#"
       dir="#expandPath('.')#\images\"
       filters="#filters#"
       onComplete="reloadPage" />

and this is the script I'm calling:

function reloadPage(){
      window.location.reload();
   }
#7 by Dan Vega on 7/29/09 - 1:32 PM

I am not sure how it would fire before the uploads were done because the external interface can not be called until those are complete. Did you look in the demo folder? I have an advanced on complete example that shows an example of listing the files after they were uploaded
#8 by Ken Smith on 8/3/09 - 2:48 PM

Hey Dan,

Maybe I don't understand, but on your onComplete.cfm example, if you just put an alert in the logFiles function, and then try to upload 20 images, the alert comes back immediately, while the files are still being uploaded in the background. This would work if your upload is instantaneous, but we are actually sending all of these images to Amazon s3, and it takes up to a couple of seconds per file.

From what I can gather, when the oncomplete fires, it has called the uploader page for each file, but those pages have not come back yet.

Would it be possible to get the flex source for the cfmu.swf file? I think we can leverage a callback function to let cfmu.swf know that the upload function has finished.
#9 by Ken Smith on 8/3/09 - 3:01 PM

Add this to uploader.cfc before the cflog line, to simulate a slow upload:

<cfscript>
go_to = createObject("java", "java.lang.Thread");
go_to.sleep(10000);
</cfscript>
#10 by Adam Lepp on 8/3/09 - 4:00 PM

I'm also having problems with the onComplete functionality. It seams the, like mentioned above, to be firing early. I'm not going to pretend to know what I'm talking about here, Colfusion is a new language to me and I don't mess with Javascript much, but it look like it is firing as soon as the uploads are complete, but it doesn't leave any time for the contents of my ImageHandler.cfc to execute.

I'm doing some some image resizing and database inserts from there and need to wait until the those are done before letting the onComplete execute.

Thanks,
Adam
#11 by Dan Vega on 8/3/09 - 4:17 PM

Nice catch guys! I am Actually looping the files array and sending them out for upload. Right after that I am doing a call to the external interface. This method should get called when the file has actually been uploaded. Do you think we should call this method after each file is uploaded, after all files are uploaded or make it a configuration option. I think making it configurable makes the most sense but I would like to hear what you guys think. I will try and get this fixed ASAP.
#12 by Adam Lepp on 8/3/09 - 4:19 PM

If I understood your question right, I think it would be nice to have two methods:

onComplete - after each file upload
onCompleteAll - after all files are uploaded

Thanks,
Adam
#13 by Dan Vega on 8/3/09 - 4:24 PM

What if the tag had the following configuration options. Is it 2 much or should we do the 2nd set?

onComplete="yourFuncName"
onCompleteAfterEach="true|false"
onCompleteAfterAll="true|false"

onComplete="yourFuncName"
onCompleteRun="aftereach|afterall"
#14 by Dan Vega on 8/3/09 - 9:34 PM

I have a fix for this but not what I posted above. All the fix does is pass the file reference when the upload is completed. I am on the fence on adding any more complexity because if you really want to you can use JS to store an array of every file as they come over.

Anyone willing to test this for me before I push this up to RIAForge? Thanks for you help guys!
#15 by Ken Smith on 8/4/09 - 12:38 PM

I'll definitely test it, Dan. I would say the 2 options (onCompleteEach and OnCompleteAll) would be the simplest solution, but whatever you have come up with I'm sure will work well.

Thanks,
#16 by Ken Smith on 8/4/09 - 12:42 PM

Didn't see #14 before I posted. All I care about is when all files have finished uploading, being able to call a js function. Drop me an email if you'd like me to test.
#17 by Dan B. on 8/17/10 - 3:04 PM

I have been using cfmu on and off for a few years now and I have just ran into something odd.

Using flash player 10,1,82 the "onComplete" doesn't seem to function. In fact it seems like it is silently failing with some sort of error there and not calling the javascript, and not proceeding to the next file.

Is there something I can do to fix this? I'm not on CF9 on all my sites yet so can't use the new fileuploader built-in to cf9.

Dan
#18 by Kris on 3/8/11 - 5:00 AM

Hi Dan,

Let me say how great this is, I want to implement it into my site but there is one issue holding me back

The maxfilesize attribut is not working on my local server or webhosted server.
It displays the message correctly if the file does exceed the maxFileSize but if you up the value to say maxFileSize="300000" and upload an image below that value it just doesn't show up in the list and can't be uploaded.

Could the message be a bit more friendly like "The file 123.gif exceeds the max file size of 300kB" instead of "The file 123.gif exceeds the max file size of 300"

thanks for otherwise a great application

p.s. I tried in IE8 and FF3.6.15

Kris
#19 by notverybright on 4/27/12 - 12:37 AM

Hi Dan,

I'm also having problems with the onComplete function. It seems it's failing and not generating any errors. The function is not even called, i think. I'm using flash version 11.2.202.233 on Windows 7 (64-bit).

Regards
notverybright
#20 by notthatbright on 4/27/12 - 1:21 AM

Hi Dan,

Additionally this is what i get as output from flash
Error: Error #2014: Feature is not available at this time.
   at flash.net::FileReference/get data()
   at flash.external::ExternalInterface$/_objectToJS()
   at flash.external::ExternalInterface$/_toJS()
   at flash.external::ExternalInterface$/call()
   at cfmu/uploadComplete()

Regards
-not that bright
#21 by Dan Vega on 5/14/12 - 8:51 AM

What version of ColdFusion are you using? If you are using 9 multi file uploads are pretty easy now and if you're not you should really look into upgrading. I am sorry but I haven't touched this project in 3 years and have no idea what would be causing that issue.